Refactoring a few tests down to oneline since they're easily understa…

…ndable
TonyBrobston · Aug 3, 2016 · 4febd70 · 4febd70
1 parent 0ebc5fb
commit 4febd70
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 19 deletions.
diff --git a/src/test/java/com/vendingmachine/domain/ProductTest.java b/src/test/java/com/vendingmachine/domain/ProductTest.java
@@ -16,9 +16,9 @@
 public class ProductTest {
     @DataProvider
     public static Object[][] productConverterDataProvider() {
-        return new Object[][] {
-                { "chips", CHIPS },
-                { "Candy", CANDY }
+        return new Object[][]{
+                {"chips", CHIPS},
+                {"Candy", CANDY}
         };
     }
 
@@ -30,22 +30,16 @@ public void shouldConvertStringsToBigDecimalInSetter(String in, BigDecimal out)
 
     @DataProvider
     public static Object[][] isEnoughCoinDataProvider() {
-        return new Object[][] {
-                { new BigDecimal(0.75), CHIPS, true },
-                { new BigDecimal(0.25), CHIPS, false },
-                { null, CHIPS, false }
+        return new Object[][]{
+                {new BigDecimal(0.75), CHIPS, true},
+                {new BigDecimal(0.25), CHIPS, false},
+                {null, CHIPS, false}
         };
     }
 
     @Test
     @UseDataProvider("isEnoughCoinDataProvider")
     public void shouldPassIfIsEnoughCoinForProduct(BigDecimal runningTotal, BigDecimal value, boolean expected) {
-        Product product = new Product().setValue(value);
-
-        boolean isEnoughForProduct = product.isEnoughCoin(runningTotal);
-
-        assertEquals(expected, isEnoughForProduct);
+        assertEquals(expected, new Product().setValue(value).isEnoughCoin(runningTotal));
     }
-
-
 }
diff --git a/src/test/java/com/vendingmachine/utils/FormatterTest.java b/src/test/java/com/vendingmachine/utils/FormatterTest.java
@@ -10,10 +10,6 @@
 public class FormatterTest {
     @Test
     public void shouldFormatMoney() {
-        BigDecimal bigDecimal = new BigDecimal(13.37);
-
-        String currency = new Formatter().toCurrency(bigDecimal);
-
-        assertEquals("$13.37", currency);
+        assertEquals("$13.37", new Formatter().toCurrency(new BigDecimal(13.37)));
     }
 }