-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Append new headers to the client when reconnecting #865
Comments
If this is planned as a new-feature or as an enhancement, I would like to help. |
Maybe simple adding a setter would be enough? |
We could add a method to put additional headers and it could initialize I also added a method to remove a header since a user may not want to send every header on every call to |
@haruntuncay You can submit multiple PRs at once, you just need to submit them from different branches. In general it's a good idea to work on code in feature branches, rather than your master branch like you did with the currently open PR. |
Thank you for the notice. I wasn't aware that we could submit multiple PRs simultaneously. |
Add a way to put additional headers to handshake for connecting/reconnecting, see #865
Resolved #868 |
Is your feature request related to a problem? Please describe.
I'm developing a client for an app that accepts a Resume-Id header when reconnecting for resuming a session. For now it looks like it's impossible to alter the list of headers which is a requirement for that kind of stuff
Describe the solution you'd like
Allow headers to be added, maybe only when socket is not connected.
Describe alternatives you've considered
It can be a .addHeader function, or a hook "onBeforeConnect" to add headers there
The text was updated successfully, but these errors were encountered: