Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Sec-WebSocket-Protocol less strict #1034

Merged
merged 2 commits into from
Jun 29, 2020
Merged

Make Sec-WebSocket-Protocol less strict #1034

merged 2 commits into from
Jun 29, 2020

Conversation

marci4
Copy link
Collaborator

@marci4 marci4 commented May 28, 2020 •
edited
Loading

Description

Make protocol less strict

Related Issue

Fixes #1008

Motivation and Context

Reduce frustration

How Has This Been Tested?

New tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@marci4 marci4 added this to the Release 1.5.2 milestone May 28, 2020
@marci4 marci4 marked this pull request as ready for review May 28, 2020 18:49
@marci4 marci4 requested a review from PhilipRoman June 29, 2020 13:47
@marci4 marci4 merged commit 866ec85 into TooTallNate:master Jun 29, 2020
@marci4 marci4 deleted the Issue1008 branch June 29, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilipRoman PhilipRoman PhilipRoman approved these changes

Assignees
No one assigned
Labels
Client Documentation New Feature Server
Projects
None yet
Milestone
Release 1.5.2
Development

Successfully merging this pull request may close these issues.

Improve Sec-WebSocket-Protocol usability
2 participants
@marci4 @PhilipRoman