Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

high cpu when channel close exception fix #1212

Merged
merged 1 commit into from
Jan 2, 2022
Merged

high cpu when channel close exception fix #1212

merged 1 commit into from
Jan 2, 2022

Conversation

Adeptius
Copy link
Contributor

@Adeptius Adeptius commented Jan 2, 2022

Description

There can be IOException when trying to close channel. That create infinitive loop.

Related Issue

#459 #458

How Has This Been Tested?

Tested on my production one week. Standart connection count from 500 up to 2k

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@marci4 marci4 requested a review from PhilipRoman January 2, 2022 13:00
PhilipRoman
PhilipRoman approved these changes Jan 2, 2022
View reviewed changes
Copy link
Collaborator

@PhilipRoman PhilipRoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@marci4 marci4 added the Bug label Jan 2, 2022
@marci4 marci4 added this to the Release 1.5.3 milestone Jan 2, 2022
@marci4 marci4 merged commit c2d0873 into TooTallNate:master Jan 2, 2022
@marci4 marci4 added the wss label Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilipRoman PhilipRoman PhilipRoman approved these changes

Assignees
No one assigned
Labels
Bug wss
Projects
None yet
Milestone
Release 1.5.3
Development

Successfully merging this pull request may close these issues.
3 participants
@Adeptius @PhilipRoman @marci4