This repository has been archived by the owner on May 5, 2023. It is now read-only.
close free sockets #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense. Thanks for the patch. Any idea why the tests are failing? 🤔 |
|
@TooTallNate fixed :) |
This was referenced Jul 2, 2018
tareksha
force-pushed
the
patch-1
branch
2 times, most recently
from
3d72efa
to
2af5128
Compare
|
Thanks @tareqhs. Sorry for not mentioning this before, but is it possible in this case to add a regression test? |
|
@tareqhs Much thanks! You're my hero for today. 💯 |
|
@TooTallNate done |
|
any decisions here? |
|
Merged and released in v4.2.1. Thanks! |
|
So was this supposed to fix npm? Because with npm v6.14.6 on nodejs v12.18.3 on Ubuntu focal, I have the same issue again with maxsockets being ignored. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is discussed thoroughly here
zkat/pacote#138
The various fetching libraries signal free proxy sockets with
freeevent. Close the socket instead of leaving them uncontrollably open and eventually exploding due to high number of open connections. This is a major blocker in some cases because some corporate proxies have hard limits on concurrently open connections.