Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle <null /> nodes when parsing plist #120

Merged
merged 2 commits into from
Apr 26, 2022

Conversation

trufae
Copy link
Contributor

@trufae trufae commented Apr 26, 2022

No description provided.

@mreinstein
Copy link
Collaborator

test(s) please

@trufae
Copy link
Contributor Author

trufae commented Apr 26, 2022

I dont think the CI is testing anything right now because the testsuite was failing with this patch (as it should).. im going to submit another PR enabling github ci tests for different versions of nodejs.

thanks for the reviews and patience 🙇

@mreinstein
Copy link
Collaborator

enabling github ci tests for different versions of nodejs.

You can assume node 14 and up. node 12 and below aren't even maintained anymore.

@mreinstein mreinstein merged commit c1a299b into TooTallNate:master Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants