Fix invalid plist build when serializing a null #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
just rebased the pr after 4 years. any chance this can be reviewed/merged before i die? |
|
add test(s) please. |
|
4 years ago i had the reproducer..now it will take me more time.. but i think it's worth to get this project into a better shape and i'll update with tests. thanks for commenting |
|
Ready to review+merge now |
|
thanks! |
|
something to note: this can't be published to npm until we bump the major version number. It probably makes sense to try to lump in some other API breaking changes together. I don't know if you have any interest in participating in that work, but I've outlined some thoughts on what could go into a plist.js v4 in #113 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.