Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example to find "bad" tokens #333

Merged
merged 1 commit into from
Jul 18, 2019
Merged

Update example to find "bad" tokens #333

merged 1 commit into from
Jul 18, 2019

Conversation

sidhantpanda
Copy link
Contributor

Failed tokens can be found with a single filter operation over the registrationTokens using the 1:1 mapping with response data. Earlier example used map + filter to achieve the same result.

Failed tokens can be found with a single `filter` operation over the `registrationTokens` using the 1:1 mapping with response data. Earlier example used `map` + `filter` to achieve the same result.
@eladnava
Copy link
Collaborator

eladnava commented Jun 2, 2019

Hi @sidhantpanda,
Thanks so much for simplifying the example code.

@hypesystem approve?

Copy link
Collaborator

@hypesystem hypesystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

(Sorry about the slow response...)

@hypesystem hypesystem merged commit 8bae681 into ToothlessGear:master Jul 18, 2019
@sidhantpanda sidhantpanda deleted the patch-1 branch July 18, 2019 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants