-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed typings for event handlers on the DBLWebhook class #26
Conversation
What exactly is being "fixed" here? |
When using dbl.webhook.on("ready", (hook) => {
console.log(
`Webhook running at https://${hook.hostname}:${hook.port}${hook.path}`
);
}); This is because the typing file says that the callback function's signature should be like this: (hostname: string, port: number, path: string) => void which is not correct. The correct signature is something like this: ({hostname: string, port: number, path: string}) => void Same thing for the |
Alright, looks good to me but I am not a typescript user. |
Sorry, I forgot to sign commits last time. So I had to commit again. |
You rock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ty
No description provided.