Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jena to 4.6.1, and slf4j to 1.7.36 #154

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

lolgab
Copy link
Contributor

@lolgab lolgab commented May 28, 2023

Didn't update to latest because Jena 4.7.0 removed RecursiveElementVisitor and I don't know how to replace it yet.
I think we can split the update in two steps. First merging this PR and then updating to 4.8.0 in a separate one.
I also updated to the latest patch release of slf4j 1.7.

Opened an issue here

pom.xml Outdated Show resolved Hide resolved
@HolgerKnublauch
Copy link
Collaborator

We have an internal branch under review to update our product to Jena 4.8 and I will compare how much work it will be to hand-pick the changes into the open source project, likely this week.

Co-authored-by: Andy Seaborne <andy@apache.org>
@lolgab
Copy link
Contributor Author

lolgab commented Sep 27, 2023

Any updates @HolgerKnublauch ?

@HolgerKnublauch
Copy link
Collaborator

Sorry, I am too busy right now and should probably hand this project over to someone else. It has diverged too much from what we use in our product and I am not seeing enough benefits to maintain it further at the moment.

@afs
Copy link
Contributor

afs commented Sep 28, 2023

From apache/jena/issues/1887 :

RecursiveElementVisitor is a do-nothing class that wasn't being used in Jena. The contract wasn't getting maintained.

Ideally, use a regular ElementVisitor. The SHACL code is all "startElement" calls so it looks like ElementVisitor.visit will work.

Otherwise, take a copy of the code.

@lolgab
Copy link
Contributor Author

lolgab commented Sep 28, 2023

Sorry, I am too busy right now and should probably hand this project over to someone else. It has diverged too much from what we use in our product and I am not seeing enough benefits to maintain it further at the moment.

Any chance your new SHACL implementation will be open-sourced?

@HolgerKnublauch
Copy link
Collaborator

Any chance your new SHACL implementation will be open-sourced?

No, because that depends on quite some code that is outside of the open source project.

@asajim
Copy link

asajim commented Dec 13, 2023

@HolgerKnublauch any update?

@HolgerKnublauch
Copy link
Collaborator

@asajim no I have no time for major work on this API right now. I welcome PRs.

@asajim
Copy link

asajim commented Dec 13, 2023

@HolgerKnublauch I understand. Can you approve this PR then? or is there an issue that we have to address first?

@HolgerKnublauch
Copy link
Collaborator

Fine. Did it pass the test cases?

@asajim
Copy link

asajim commented Dec 20, 2023

@HolgerKnublauch yes it does. I've tested in my own project as well

@HolgerKnublauch HolgerKnublauch merged commit c8dae1f into TopQuadrant:master Dec 20, 2023
@lolgab lolgab deleted the update-jena branch December 20, 2023 13:40
@asajim
Copy link

asajim commented Dec 20, 2023

@HolgerKnublauch can you release new version (1.4.3) please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants