-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pushed Jena version to 5.0.0 and updated Caching library #177
Conversation
@@ -72,7 +72,7 @@ public MultiUnion createMultiUnion(Graph[] graphs) { | |||
* @return the default Graph | |||
*/ | |||
public Graph createDefaultGraph() { | |||
return Factory.createDefaultGraph(); | |||
return GraphFactory.createDefaultGraph(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: Should this be a call to `JenaUtil.createDefaultGraph()?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason JenaUtil.createDefaultGraph()
is calling the helper class, causing a stack overflow cycle
This is what there is in JenaUtil.
public static Graph createDefaultGraph() { return helper.createDefaultGraph(); }
Maybe this needs to be changed?
That comment was for why I did not use If you are using java 21 or 22, you can download my branch and use it. I am using it for project work and training and so far it seems to work well |
The latest Jena release is 5.2.0. |
@jerdebsp, if you update Jena to the latest version, maybe @ashleycaselli, or @HolgerKnublauch could have a look at the CI issue and merge this? |
I will try to update to Jena 5.2.0 by end of next week |
I tested 5.2.0 on my machine and seems to work, however, it only makes sense to update once this PR is merged. |
@jerdebsp can you please update the JDK used in the maven-test-pr.yml to Java 17 (Jena5 requires that)? Also, before merging the PR we would need to update the JRE versions used as base images for building the docker image (docker-image.yml). |
@ashleycaselli done. when this is merged i'll move with updating to 5.2.0 |
Thanks! Lastly, the |
Don't wait for my feedback here as I don't really have time to follow the details of this repo anymore. We have completely moved in our code base to Java 17 last year and didn't encounter problems. |
For docker, the image can jump to Java21 runtime, even if the code only requires Java17. Jena already builds with Java21 (targeting Java17) and runs on Java21. Java25 is LTS in September 2025. Sometime after, when it's clear Java25 is established, Jena will highly likely move to supporting Java21 and Java25, dropping Java17. Apache Lucene 10 requires Java21. |
Hi,
I was having trouble using 1.4.3 due to Jena classes deprecated or removed - more specifically org.apache.jena.graph.Factory. In my pull request, i've updated Jena to the latest version and also updated the Caching library to use benmanes (https://github.com/ben-manes/caffeine) which is compatible with the previously used library. I believe that the library used in the main fork is not available anymore.
Thanks,
Jeremy
PS. I couldn't assign anyone as reviewer. I guess Holger or Ashley can do this.