Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show query in user search header #1329

Merged
merged 1 commit into from
Sep 28, 2024
Merged

Show query in user search header #1329

merged 1 commit into from
Sep 28, 2024

Conversation

Torgen
Copy link
Owner

@Torgen Torgen commented Sep 28, 2024

Also close dropdown on enter, and allow clearing search without reopening dropdown.

Fixes #1316

Also close dropdown on enter, and allow clearing search without reopening dropdown.

Fixes #1316
Copy link

Bundle size diff:

Format Base Head Diff
Minified 1025206 1025943 +737
Gzipped 272692 272787 +95
CSS 172933 173141 +208

Meteor Package size diff:

Package Base Head Diff
app/app.js 377514 378251 +737

No change in top-level node module sizes.

Copy link

codecov bot commented Sep 28, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.49%. Comparing base (967bfe3) to head (12689c4).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
client/blackboard.js 75.00% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1329      +/-   ##
==========================================
+ Coverage   82.27%   82.49%   +0.21%     
==========================================
  Files         114      114              
  Lines        7194     7202       +8     
  Branches     1350     1350              
==========================================
+ Hits         5919     5941      +22     
+ Misses        921      910      -11     
+ Partials      354      351       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Torgen Torgen merged commit 99ba16f into master Sep 28, 2024
24 of 25 checks passed
@Torgen Torgen deleted the show-filter-in-header branch September 28, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indication of nick filtering
1 participant