Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column options refinements #1330

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Column options refinements #1330

merged 4 commits into from
Oct 2, 2024

Conversation

Torgen
Copy link
Owner

@Torgen Torgen commented Oct 1, 2024

  • Rename "Visible Columns" submenu to "Column Options".
  • Add Name as a disabled setting in "Column Options" since you can't hide it.
  • Rename "Compact Mode" to "Hide Tags" and nest under "Name"
  • Add "Added" column, hidden by default.
  • Add display style option for "Who's Working"

Fixes #1327

Rename "Visible Columns" submenu to "Column Options".
Add Name as a disabled setting in "Column Options" since you can't hide it.
Rename "Compact Mode" to "Hide Tags" and nest under "Name"
Add "Added" column, hidden by default.
Add display style option for "Who's Working"

This comment has been minimized.

This comment has been minimized.

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.58%. Comparing base (99ba16f) to head (c950ea0).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
client/imports/settings.js 92.00% 2 Missing ⚠️
client/options_dropdown.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1330      +/-   ##
==========================================
+ Coverage   82.37%   82.58%   +0.20%     
==========================================
  Files         114      114              
  Lines        7202     7222      +20     
  Branches     1350     1354       +4     
==========================================
+ Hits         5933     5964      +31     
+ Misses        914      911       -3     
+ Partials      355      347       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This comment has been minimized.

Copy link

github-actions bot commented Oct 2, 2024

Bundle size diff:

Format Base Head Diff
Minified 1025146 1028926 +3780
Gzipped 272613 273398 +785
CSS 173141 173400 +259

Meteor Package size diff:

Package Base Head Diff
app/app.js 377454 381234 +3780

No change in top-level node module sizes.

@Torgen Torgen merged commit ca24e51 into master Oct 2, 2024
25 checks passed
@Torgen Torgen deleted the per-column-options branch October 2, 2024 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make an intermediate compact mode
1 participant