fix: too many temporary allocation when serializing data #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Totodore
force-pushed
the
fix-temp-alloc-parser
branch
from
20a6c47 to
c86f0e6
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -1,7 +1,7 @@ | |||
| //! This module contains a specialized JSON serializer wrapper that can serialize binary payloads as placeholders. | |||
| use std::{cell::UnsafeCell, collections::VecDeque}; | |||
|
|
|||
| use bytes::Bytes; | |||
| use bytes::{BufMut, Bytes, BytesMut}; | |||
Check warning
Code scanning / clippy
unused imports: BufMut and BytesMut Warning
| @@ -1,7 +1,7 @@ | |||
| //! This module contains a specialized JSON serializer wrapper that can serialize binary payloads as placeholders. | |||
| use std::{cell::UnsafeCell, collections::VecDeque}; | |||
|
|
|||
| use bytes::Bytes; | |||
| use bytes::{BufMut, Bytes, BytesMut}; | |||
Check warning
Code scanning / clippy
unused imports: BufMut and BytesMut Warning
| @@ -1,7 +1,7 @@ | |||
| //! This module contains a specialized JSON serializer wrapper that can serialize binary payloads as placeholders. | |||
| use std::{cell::UnsafeCell, collections::VecDeque}; | |||
|
|
|||
| use bytes::Bytes; | |||
| use bytes::{BufMut, Bytes, BytesMut}; | |||
Check warning
Code scanning / clippy
unused imports: BufMut and BytesMut Warning
| @@ -1,7 +1,7 @@ | |||
| //! This module contains a specialized JSON serializer wrapper that can serialize binary payloads as placeholders. | |||
| use std::{cell::UnsafeCell, collections::VecDeque}; | |||
|
|
|||
| use bytes::Bytes; | |||
| use bytes::{BufMut, Bytes, BytesMut}; | |||
Check warning
Code scanning / clippy
unused imports: BufMut and BytesMut Warning
Totodore
force-pushed
the
fix-temp-alloc-parser
branch
from
c86f0e6 to
d193e86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When serializing packet, the initial buffer is a
Vec<u8>which is then converted to aBytes. Becauselen != capwhen converting the buffer. A new allocation is made. Leading to a lot of temporary allocations.Solution
Directly serialize to a
BytesMutwriter.