-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P2: [LILA-5515]: create example frontend implementations repository #24
Merged
GigaHierz
merged 8 commits into
ToucanProtocol:main
from
GigaHierz:LILA-5515/create-example-frontend-implementations-repository
Oct 17, 2023
Merged
P2: [LILA-5515]: create example frontend implementations repository #24
GigaHierz
merged 8 commits into
ToucanProtocol:main
from
GigaHierz:LILA-5515/create-example-frontend-implementations-repository
Oct 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Niwilai
reviewed
Oct 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First round of feedback, I will have another look once the current feedback is addressed.
Niwilai
reviewed
Oct 7, 2023
Niwilai
reviewed
Oct 10, 2023
Niwilai
reviewed
Oct 10, 2023
647389a
to
af41f55
Compare
… to "pool token" add hint for `expectedToken`functions for `autoOffsetExactInx`functions
af41f55
to
735f7f3
Compare
Niwilai
reviewed
Oct 17, 2023
Niwilai
reviewed
Oct 17, 2023
75045bc
to
867f656
Compare
Niwilai
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alrighty, all g 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.