Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

estimate tco2 redemption amount given pool redemption amount #40

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

estimate tco2 redemption amount given pool redemption amount #40

wants to merge 13 commits into from

Commits on Jan 25, 2024

  1. extract out calculateRedemptionFee function from calculateRedemptionF… 

    …ees function
    @PawelTroka
    PawelTroka committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    1faa36b View commit details
    Browse the repository at this point in the history

  2. add estimateTCO2RedemptionAmount function with a simple linear implem… 

    …entation
    @PawelTroka
    PawelTroka committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    e422021 View commit details
    Browse the repository at this point in the history

  3. add tests for checking slippage of estimateTCO2RedemptionAmount

    @PawelTroka
    PawelTroka committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    8b6a55d View commit details
    Browse the repository at this point in the history

  4. add fuzzy tests for checking slippage of estimateTCO2RedemptionAmount

    @PawelTroka
    PawelTroka committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    3711827 View commit details
    Browse the repository at this point in the history

  5. change estimateTCO2RedemptionAmount function to a bisection implement… 

    …ation
    @PawelTroka
    PawelTroka committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    9128b99 View commit details
    Browse the repository at this point in the history

  6. decrease maximum allowed slippage for estimateTCO2RedemptionAmount to 1%

    @PawelTroka
    PawelTroka committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    99dc221 View commit details
    Browse the repository at this point in the history

  7. reformat code

    @PawelTroka
    PawelTroka committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    a6c7d09 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. add setEstimateTCO2RedemptionAmountIterations so that the number of i… 

    …terations in estimation algorithm can be set up after deploying the contract
    @PawelTroka
    PawelTroka committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    6e2c991 View commit details
    Browse the repository at this point in the history

  2. fix tests for estimateTCO2RedemptionAmount not using the estimated re… 

    …demption amount to calculate estimated pool amount
    @PawelTroka
    PawelTroka committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    ba99870 View commit details
    Browse the repository at this point in the history

  3. add test for setEstimateTCO2RedemptionAmountIterations showing that w… 

    …ith increased iterations it lowers slippage
    @PawelTroka
    PawelTroka committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    af5cafb View commit details
    Browse the repository at this point in the history

  4. add return value name in interface for estimateTCO2RedemptionAmount 

    Co-Authored-By: Michalis Kargakis <kargakis@protonmail.com>
    @PawelTroka @0xmichalis
    PawelTroka and 0xmichalis committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    9cc622a View commit details
    Browse the repository at this point in the history

  5. remove or document limitations in estimateTCO2RedemptionAmount fuzzy … 

    …tests
    @PawelTroka
    PawelTroka committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    ceb329b View commit details
    Browse the repository at this point in the history

  6. document in dev section the expected usage of estimateTCO2RedemptionA… 

    …mount function
    @PawelTroka
    PawelTroka committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    abc2e59 View commit details
    Browse the repository at this point in the history