Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: encoding should be kept as None by default + pin pandas to v1.2.5 #122

Merged
merged 2 commits into from
Apr 8, 2022

Conversation

PrettyWood
Copy link
Member

Change Summary

Related issue number

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #122 (cd26af8) into main (5d7e6c8) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #122   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          770       770           
=========================================
  Hits           770       770           
Impacted Files Coverage Δ
peakina/datasource.py 100.00% <100.00%> (ø)
peakina/helpers.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d7e6c8...cd26af8. Read the comment docs.

@PrettyWood PrettyWood changed the title fix: encoding should be kept as None by default fix: encoding should be kept as None by default + pin pandas to v1.2.5 Apr 8, 2022
"aaaa-aa-aa aa:aa:aa";"aaaa";"aaaa-aaa";"aaaa_a";"aaaaaaaaaa a�aaaaa�a aa";"aaa";"";"aaaaaaaa aaaa";"aaaaaaaa aaaaaaa";"a_aaaaa_aa";"aaa a aaa";"aaaaaaaaaaaaa";"aaaaaa";"aaaaaaaaaa";"";"aaaaaa aa";"aaaaaa aa";"aa.aa";""
"aaaa-aa-aa aa:aa:aa";"aaaa";"aaaa-aaa";"aaaa_a";"aaaaaaaaaa a�aaaaa�a aa";"aaa";"";"aaaaaaaa aaaa";"aaaaaaaa aaaaaaa";"a_aaaaa_aa";"aaa a aaa";"aaaaaaaaaaaaa";"aaaaaa";"aaaaaaaaaa";"";"aaaaaa aa";"aaaaaa aa";"aa.aa";""
"aaaa-aa-aa aa:aa:aa";"aaaa";"aaaa-aaa";"aaaa_a";"aaaaaaaaaa a�aaaaa�a aa";"aaa";"";"aaaaaaaa aaaa";"aaaaaaaa aaaaaaa";"a_aaaaa_aa";"aaa a aaa";"aaaaaaaaaaaaa";"aaaaaa";"aaaaaaaaaa";"";"aaaaaa aa";"aaaaaa aa";"aa.aa";""
"aaaa-aa-aa aa:aa:aa";"aaaa";"aaaa-aaa";"aaaa_a";"aaaaaaaaaa a�aaaaa�a aa";"aaa";"";"aaaaaaaa aaaa";"aaaaaaaa aaaaaaa";"a_aaaaa_aa";"aaa a aaa";"aaaaaaaaaaaaa";"aaaaaa";"aaaaaaaaaa";"";"aaaaaa aa";"aaaaaa aa";"aa.aa";""
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"aaaa-aa-aa aa:aa:aa";"aaaa";"aaaa-aaa";"aaaa_a";"aaaaaaaaaa a�aaaaa�a aa";"aaa";"";"aaaaaaaa aaaa";"aaaaaaaa aaaaaaa";"a_aaaaa_aa";"aaa a aaa";"aaaaaaaaaaaaa";"aaaaaa";"aaaaaaaaaa";"";"aaaaaa aa";"aaaaaa aa";"aa.aa";""
"aaaa-aa-aa aaaaa:aa:aa";"aaaa";"aaaa-aaa";"aaaa_a";"aaaaaa a�aaaaa�a aa";"aaa";"";"aaaaaaaa aaaa";"aaaaa aaaaaaa";"a_aa_aa";"aaa a aaa";"aaaaaaaaa";"aaaaaa";"aaaaaaaaaa";"";"aaaaaa aa";"aaaaaa a";"aa.aa";""

Copy link

@austil austil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢

@PrettyWood PrettyWood merged commit 0c399c6 into main Apr 8, 2022
@PrettyWood PrettyWood deleted the fix/encoding branch April 8, 2022 13:11
@PrettyWood PrettyWood added the bug Something isn't working label Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants