feat: geodata reader #156
feat: geodata reader #156
Conversation
raphaelvignes
force-pushed
the
feat/basemap-preview
branch
2 times, most recently
from
e17b569 to
6a12fdd
Compare
raphaelvignes
force-pushed
the
feat/basemap-preview
branch
from
6a12fdd to
be6b0d6
Compare
Codecov Report
@@ Coverage Diff @@
## main #156 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 19 +1
Lines 796 806 +10
=========================================
+ Hits 796 806 +10
Continue to review full report at Codecov.
|
peakina/helpers.py
Outdated
| @@ -42,7 +43,7 @@ class TypeInfos(NamedTuple): | |||
|
|
|||
|
|
|||
| # For files without MIME types, we make fake MIME types based on detected extension | |||
| CUSTOM_MIMETYPES = {".parquet": "peakina/parquet"} | |||
| CUSTOM_MIMETYPES = {".parquet": "peakina/parquet", ".geojson": "application/geo+json"} | |||
There was a problem hiding this comment.
are we okay with enforcing this extension for basemaps ? cf. my comment here
There was a problem hiding this comment.
Is application/geo+json really a valid mimetype ? If not, I'd rather have peakina/geo to make it explicit that this is a custom mimetype. And I agree with fred's comment, the extension for geo files should probably be free (if that's possible in peakina)
There was a problem hiding this comment.
if that's possible in peakina
MimeType guessing is not working it seems :/
peakina/readers/geojson.py
Outdated
|
|
||
|
|
||
| @wraps(gpd.read_file) | ||
| def read_file( |
There was a problem hiding this comment.
maybe rename this function so it's explicit it's for geographic data
peakina/helpers.py
Outdated
| @@ -81,6 +86,7 @@ class TypeEnum(str, Enum): | |||
| JSON = "json" | |||
| PARQUET = "parquet" | |||
| XML = "xml" | |||
| GEOJSON = "geojson" | |||
There was a problem hiding this comment.
I don't think we should have GEOJSON here. I'd rather have something like GEODATA, and let it be a wildcard for everything that can be read by geopandas (even if we only support geojson in laputa for now)
peakina/helpers.py
Outdated
| @@ -42,7 +43,7 @@ class TypeInfos(NamedTuple): | |||
|
|
|||
|
|
|||
| # For files without MIME types, we make fake MIME types based on detected extension | |||
| CUSTOM_MIMETYPES = {".parquet": "peakina/parquet"} | |||
| CUSTOM_MIMETYPES = {".parquet": "peakina/parquet", ".geojson": "application/geo+json"} | |||
There was a problem hiding this comment.
Is application/geo+json really a valid mimetype ? If not, I'd rather have peakina/geo to make it explicit that this is a custom mimetype. And I agree with fred's comment, the extension for geo files should probably be free (if that's possible in peakina)
raphaelvignes
force-pushed
the
feat/basemap-preview
branch
from
3c33f84 to
70c5b7f
Compare
raphaelvignes
force-pushed
the
feat/basemap-preview
branch
from
70c5b7f to
bd79b00
Compare
Add a new geojson reader