feat(s3): raise an exception when the file cannot be access (#409) #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(s3): raise an exception when the file cannot be access * feat: trying to add more context to the exception raising * Context + coverage Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com> * test: fix typo due to update on test --------- Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com> Co-authored-by: Luka Peschke <luka.peschke@toucantoco.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #414 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 835 837 +2
=========================================
+ Hits 835 837 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Merged
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sanix-Darker
force-pushed
the
feat/s3error-context-for-file-reading
branch
from
ec17816 to
3235968
Compare
with the object path from a split i made on path, let's forward the objectname directly to see what happens
lukapeschke
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Cherry pick from this PR : #409