Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop pydantic v1 support #697

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Conversation

Sanix-Darker
Copy link
Contributor

WHAT

We now support pydanticV2, it's time to drop v1.

HOW

  • feat: remove the temp patch to fully support pydantic V2
  • chore(deps): fully support for pydantic v2
  • chore: add CHANGELOG info

@Sanix-Darker Sanix-Darker self-assigned this Jan 17, 2024
@Sanix-Darker Sanix-Darker added the enhancement New feature or request label Jan 17, 2024
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1b1cb50) 100.00% compared to head (0db0a7f) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #697   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        19           
  Lines          859       850    -9     
=========================================
- Hits           859       850    -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sanix-Darker Sanix-Darker marked this pull request as ready for review January 17, 2024 08:42
Copy link
Contributor

@lukapeschke lukapeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM but PR title is misleading, shouldn't it be something like chore: drop pydantic v1 support ?

@Sanix-Darker Sanix-Darker changed the title feat: full pydantic V2 support chore: drop pydantic v1 support Jan 17, 2024
@Sanix-Darker Sanix-Darker merged commit ffa82b2 into main Jan 17, 2024
9 checks passed
@Sanix-Darker Sanix-Darker deleted the f/full-pydanticv2-support branch January 17, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants