Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix csv reader TCTC-1973 #95

Merged
merged 1 commit into from
Mar 2, 2022
Merged

fix: fix csv reader TCTC-1973 #95

merged 1 commit into from
Mar 2, 2022

Conversation

Sanix-Darker
Copy link
Contributor

@Sanix-Darker Sanix-Darker commented Mar 2, 2022

WHAT

  • remove default preview chunksize because laputa is the one who decide for that value
  • return an iterator only if the type of the reader is not a dataframe

WHY

Screenshot from 2022-03-02 14-57-46

- remove default preview chunksize because laputa is the one who decide for that
- return an iterator only if the type of the reader is not a dataframe
@Sanix-Darker Sanix-Darker added the wip Work in progress label Mar 2, 2022
@Sanix-Darker Sanix-Darker self-assigned this Mar 2, 2022
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #95 (7ba71f0) into main (b1ff48b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #95   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          848       847    -1     
=========================================
- Hits           848       847    -1     
Impacted Files Coverage Δ
peakina/readers/csv.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1ff48b...7ba71f0. Read the comment docs.

@Sanix-Darker Sanix-Darker merged commit 750748c into main Mar 2, 2022
@Sanix-Darker Sanix-Darker deleted the fix/read-csv-chunks branch March 2, 2022 14:10
@Sanix-Darker Sanix-Darker changed the title fix: fix csv reader fix: fix csv reader TCTC-1973 Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wip Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants