fix: on read csv chunks and indexError on excel TCTC-1973 #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #96 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 847 858 +11
=========================================
+ Hits 847 858 +11
Continue to review full report at Codecov.
|
Sanix-Darker
changed the title
davinov
approved these changes
Mar 2, 2022
Sanix-Darker
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
During laputa integration, we needed to fix some errors during tests.
WHY
fix on read_csv for the iterator + added tests to handle chunksize and preview_nrows as params
fix/catch IndexError when the preview_nrows is upper than all the available row
fix retrocompatibility with read_xml
bump from 0.7.4 to 0.7.5