Mongo :: instantiate MongoClient with kwargs instead of building a connection string #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #120 +/- ##
==========================================
- Coverage 98.29% 98.23% -0.06%
==========================================
Files 33 33
Lines 1759 1758 -1
==========================================
- Hits 1729 1727 -2
- Misses 30 31 +1
Continue to review full report at Codecov.
|
fspot
reviewed
Nov 8, 2019
| @@ -305,7 +304,7 @@ def test_status_bad_host(mongo_connector): | |||
| ('Host connection', None), | |||
| ('Authenticated', None), | |||
| ] | |||
| assert 'not known' in status['error'] | |||
| assert len(status['error']) > 0 | |||
There was a problem hiding this comment.
le message d'erreur qui est renvoyé dépends de configurations système, et ne contient pas toujours la string "not known"
piotch
changed the title
piotch
changed the title
piotch
changed the title
davinov
approved these changes
Nov 13, 2019
Merged
fspot
added a commit
that referenced
this pull request
Aug 17, 2020
* unpin urllib3 (which was pinned in #120) to avoid conflicts in Toucan api with responses 0.10.16 * bump version number
raphaelvignes
pushed a commit
that referenced
this pull request
Jan 12, 2022
DataSet type is defined as two properties:
- `headers`: a list of objects defining columns
- each column is itself defined by a `name` and
an optional `type`. We'll probably add extra
metadata later,
- `data`: a list of list of values
Use this type in the `DataViewer` component.
Related to ToucanToco/weaverbird#26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instantiate
MongoClientwith kwargs rather than with a connection string built from the connector parameters.It means that it will be easier to add any supported
MongoClientkwargs at theMongoConnectorlevel.It also means that we can use a connection string in the
hostfield and leave out all the other parameters. In the end we can natively support a lot more connections options than we cover with the few parameters that we have explicitly listed inMongoConnector. cf. https://docs.mongodb.com/manual/reference/connection-string/And more specifically this means that when you create a new MongoDB Atlas cluster, you can just copy and paste the connection string that is given by Atlas into our configurations files.