feat: support Python 3.12 #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukapeschke
force-pushed
the
support-py312
branch
from
a709b63 to
018d7cc
Compare
Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
lukapeschke
force-pushed
the
support-py312
branch
from
018d7cc to
f9cbc80
Compare
Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
lukapeschke
force-pushed
the
support-py312
branch
from
601ad6d to
dae36c1
Compare
It was only used by the lightspeed connector, which has been removed in #1036 The lib has not been updated since 2019: https://pypi.org/project/bearer/, and the associated repo has been deleted. The bearer.sh service seems to have been discontinued Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
fspot
reviewed
Mar 13, 2024
| @@ -266,8 +265,8 @@ def test_get_slice_metadata(snowflake_datasource, mocker): | |||
| connect.cursor().execute().fetchall.return_value = [{"c1": 2}] | |||
| ds: DataSlice = SnowflakeCommon().get_slice(connect, snowflake_datasource) | |||
|
|
|||
| # big fun | |||
| expected_memory_size = 1364 if sys.version_info.minor == 11 else 1360 | |||
| # testing this is stupid | |||
fspot
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.