fix(elasticsearch): disable verification #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
lukapeschke
force-pushed
the
fix-disable-elasticsearch-check
branch
from
0faefa7 to
b44ce10
Compare
Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
lukapeschke
approved these changes
Jan 23, 2024
WilliamGorge
commented
Jan 23, 2024
lukapeschke
added a commit
that referenced
this pull request
Jan 23, 2024
Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com> Co-authored-by: Luka Peschke <luka.peschke@toucantoco.com>
lukapeschke
added a commit
that referenced
this pull request
Jan 23, 2024
lukapeschke
added a commit
that referenced
this pull request
Jan 23, 2024
…private key format (#1470) (#1473) * [backport] fix(elasticsearch): disable verification (#1469) Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com> Co-authored-by: Luka Peschke <luka.peschke@toucantoco.com> * feat(gbq): Implement a simple status check validating the private key format (#1470) Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com> * fix merge errors Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com> --------- Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com> Co-authored-by: William Gorge <WilliamGorge@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Disable the internal verification of the elasticsearch client that checks if the root
/of the provided URL returns a a compatible payload.This internal verification, for some reason, does not use the basic auth provided by http_auth. So this check fails when the client configuration ask for authentication for the
/route.https://github.com/elastic/elasticsearch-py/blob/v7.17.6/elasticsearch/transport.py#L532
https://github.com/elastic/elasticsearch-py/blob/v7.17.6/elasticsearch/transport.py#L216
https://toucantoco.slack.com/archives/C823R095H/p1705597838374409