Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aircall: fix "calls" datasource #156

Merged
merged 1 commit into from
Apr 23, 2020

Conversation

vdestraitt
Copy link
Contributor

Replace null values with the label 'NO TEAMS' in the column "team" of the
"calls" dataset (in coherence with what we do for the "users" dataset).

@vdestraitt vdestraitt self-assigned this Apr 23, 2020
@vdestraitt vdestraitt force-pushed the fix/aircall-connector-calls-datasource branch from b3f8e1a to 3926976 Compare April 23, 2020 16:24
Replace null values with the label 'NO TEAMS' in the column "team" of the
"calls" dataset (in coherence with what we do for the "users" dataset).
@vdestraitt vdestraitt force-pushed the fix/aircall-connector-calls-datasource branch from 3926976 to 56d8e46 Compare April 23, 2020 16:38
@codecov-io
Copy link

codecov-io commented Apr 23, 2020

Codecov Report

Merging #156 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #156   +/-   ##
=======================================
  Coverage   97.52%   97.52%           
=======================================
  Files          42       42           
  Lines        2097     2097           
=======================================
  Hits         2045     2045           
  Misses         52       52           
Impacted Files Coverage Δ
toucan_connectors/aircall/helpers.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d16583...56d8e46. Read the comment docs.

@vdestraitt vdestraitt merged commit 845c869 into master Apr 23, 2020
@vdestraitt vdestraitt deleted the fix/aircall-connector-calls-datasource branch April 23, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants