Prevent mongo connector to count more than 1M rows #159
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Trying to
get_slice
on a very large collection (25M rows) was very slow (1min30).This is caused by the count facet, which forces mongo to scan all docs regardless of the limit.
I suggest we limit this to a somewhat high value, but that doesn't impact too much performance.
I choose 1M, because it took 3s on my local mongo, and seems a nice threshold above which the exact count is not very relevant.
Checklist