refactor(azure_mssql): use sqlalchemy for connections [TCTC-9751] #1841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
julien-pinchelimouroux
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Ok pour moi, ca vaut peut etre le coup que @fspot y jette un oeil aussi :)
toucan_connectors/common.py
Outdated
| def create_sqlalchemy_engine(url: "sa.URL") -> "sa.Engine": | ||
| """Creates an SQLAlchemy engine for the given URL. | ||
|
|
||
| Sets sensible connector-specific defaults, such as disabling conneciton pooling. |
There was a problem hiding this comment.
"connection"
lukapeschke
commented
Dec 2, 2024
Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.