Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gsheets2): retrieve unformatted values instead of formatted ones #214

Merged
merged 7 commits into from
Sep 21, 2020

Conversation

testinnplayin
Copy link
Contributor

@testinnplayin testinnplayin commented Sep 21, 2020

Change Summary

By default google sheets applies the decimal separator defined in the gsheet locale.
We want values such as "," to be correctly interpreted so we added the parameter valueRenderOption=UNFORMATTED_VALUE' to the URL used to retrieve data in the connector

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable

@testinnplayin testinnplayin self-assigned this Sep 21, 2020
@codecov
Copy link

codecov bot commented Sep 21, 2020

Codecov Report

Merging #214 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #214   +/-   ##
=======================================
  Coverage   97.75%   97.75%           
=======================================
  Files          43       43           
  Lines        2223     2223           
=======================================
  Hits         2173     2173           
  Misses         50       50           
Impacted Files Coverage Δ
...ctors/google_sheets_2/google_sheets_2_connector.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4aa65c...ead31a5. Read the comment docs.

@testinnplayin testinnplayin changed the title F/handle gsheet decimal 2 feat(gsheets2): retrieve unformatted values instead of formatted ones Sep 21, 2020
@testinnplayin testinnplayin force-pushed the f/handle-gsheet-decimal-2 branch from 50e2744 to 8d46a2e Compare September 21, 2020 15:21
@raphaelvignes
Copy link
Contributor

We created a new PR based on (#210) to integrate changes from Rachelle PR

@testinnplayin testinnplayin merged commit 4c86def into master Sep 21, 2020
@testinnplayin testinnplayin deleted the f/handle-gsheet-decimal-2 branch September 21, 2020 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants