Supporting the Max and Min value for FLOAT parameters. Supporting the Min and Max value from register and not only from formula #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not only the formula
…not only the formula
…not only the formula
CosbyBs86
changed the title
Fixing an error on compiling time
|
Hello @Touseefelahi can you have a look on this PR? many thanks |
|
Hello @CosbyBs86, Thank you for the PR, I really appreciate the effort. |
|
Thank you @Touseefelahi for approving the PR. It is a pleasure to contribute in such library. I have two more PR and then I finished for the moment. I swear :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even for generic and float parameter the system should support the Max and Min values of the parameter. The PMin and PMax should also be able to support registers and not only formulas