Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Pl3xMap v3 Support #45

Merged
merged 13 commits into from
May 15, 2023
Merged

Adding Pl3xMap v3 Support #45

merged 13 commits into from
May 15, 2023

Conversation

Agaloth
Copy link
Contributor

@Agaloth Agaloth commented May 5, 2023

Haven't tested it in-game yet, just focused on fixing all errors between v2 and v3 and this doesn't have any other errors.

@Agaloth
Copy link
Contributor Author

Agaloth commented May 6, 2023

Just pushed a new pull request, I compiled the plugin and tested it on my local server, and everything works perfectly.

image
image
image
image

pom.xml Outdated Show resolved Hide resolved
Copy link
Member

@Warriorrrr Warriorrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .iml files should be removed from this PR as they're in the gitignore, the changes to the jitpack_toolchain.xml file can also be undone.

@Agaloth
Copy link
Contributor Author

Agaloth commented May 7, 2023

The .iml files should be removed from this PR as they're in the gitignore, the changes to the jitpack_toolchain.xml file can also be undone.

Thanks, done!

Thanks Warrior for the help.
@Agaloth
Copy link
Contributor Author

Agaloth commented May 7, 2023

Thanks @Warriorrrr for helping.

The latest commit makes it so that the plugin works on v2 (tested it) and it should also keep v1 support.

@shpellar
Copy link

bro accept this pull already

@PainOchoco
Copy link

PainOchoco commented May 10, 2023

bro accept this pull already

if you're really in a hurry, you can follow the instructions on the readme to build the plugin yourself.

@Agaloth
Copy link
Contributor Author

Agaloth commented May 10, 2023

bro accept this pull already

if you're really in a hurry, you can follow the instructions on the readme to build the plugin yourself.

Dude even asked for a jar and I gave it to him since he couldn't build it then he started suspecting me of adding a malware to it lmfao

@shpellar
Copy link

bro accept this pull already

if you're really in a hurry, you can follow the instructions on the readme to build the plugin yourself.

Dude even asked for a jar and I gave it to him since he couldn't build it then he started suspecting me of adding a malware to it lmfao

false information kkthx

@Agaloth
Copy link
Contributor Author

Agaloth commented May 11, 2023

bro accept this pull already

if you're really in a hurry, you can follow the instructions on the readme to build the plugin yourself.

Dude even asked for a jar and I gave it to him since he couldn't build it then he started suspecting me of adding a malware to it lmfao

false information kkthx

image
image
image

Please stop creating unnecessary drama

- Fix copyright date for new files.
- Revert changes to jitpack toolchain.
@silverwolfg11 silverwolfg11 merged commit 5edde48 into TownyAdvanced:main May 15, 2023
@silverwolfg11
Copy link
Collaborator

silverwolfg11 commented May 15, 2023

Thank you so much for adding support for the new version of Pl3xMap!

I know there was some discussion about removing v1 support. However, Pl3xMap v1 is technically the only stable release of Pl3xMap. Both v2 and v3 don't have a stable release. Hence, until v3 (hopefully) has a stable release, compatibility for all v1,v2, and v3 will be kept.

P.S. Sorry for taking so long to review and merge it, but thank you for your patience.

@PainOchoco
Copy link

You can also update the readme ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants