-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Pl3xMap v3 Support #45
Conversation
maptowny-plugin/src/main/java/me/silverwolfg11/maptowny/MapTowny.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The .iml files should be removed from this PR as they're in the gitignore, the changes to the jitpack_toolchain.xml file can also be undone.
Thanks, done! |
Thanks Warrior for the help.
Thanks @Warriorrrr for helping. The latest commit makes it so that the plugin works on v2 (tested it) and it should also keep v1 support. |
bro accept this pull already |
if you're really in a hurry, you can follow the instructions on the readme to build the plugin yourself. |
Dude even asked for a jar and I gave it to him since he couldn't build it then he started suspecting me of adding a malware to it lmfao |
false information kkthx |
Please stop creating unnecessary drama |
- Fix copyright date for new files. - Revert changes to jitpack toolchain.
Thank you so much for adding support for the new version of Pl3xMap! I know there was some discussion about removing v1 support. However, Pl3xMap v1 is technically the only stable release of Pl3xMap. Both v2 and v3 don't have a stable release. Hence, until v3 (hopefully) has a stable release, compatibility for all v1,v2, and v3 will be kept. P.S. Sorry for taking so long to review and merge it, but thank you for your patience. |
You can also update the readme ;) |
Haven't tested it in-game yet, just focused on fixing all errors between v2 and v3 and this doesn't have any other errors.