Punishes players who are not participating in the siege with war sick… #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warriorrrr
reviewed
Jan 14, 2021
src/main/java/com/gmail/goosius/siegewar/settings/ConfigNodes.java
Outdated
Show resolved
Hide resolved
|
This could probably be merged with the war sickness for peaceful players somehow. The only thing is that punishing peaceful players in a siege is not configurable and this is. |
LlmDl
requested changes
Jan 14, 2021
src/main/java/com/gmail/goosius/siegewar/utils/SiegeWarSicknessUtil.java
Outdated
Show resolved
Hide resolved
…to war_sickness
LlmDl
previously approved these changes
Jan 14, 2021
…to war_sickness
LlmDl
previously approved these changes
Jan 14, 2021
Goosius1
reviewed
Jan 15, 2021
|
Goosius1
reviewed
Jan 15, 2021
src/main/java/com/gmail/goosius/siegewar/settings/ConfigNodes.java
Outdated
Show resolved
Hide resolved
Goosius1
requested changes
Jan 15, 2021
Goosius1
requested changes
Jan 18, 2021
|
Goosius1
reviewed
Jan 21, 2021
src/main/resources/english.yml
Outdated
|
|
||
| #War sickness | ||
| msg_you_received_war_sickness: '&cYou are not a participant of this siege and cannot be in the Siege Zone. Please leave to remove the war sickness. Common causes of war sickness: being in a peaceful town, not having a military rank or not being allied to either side.' | ||
| msg_you_will_get_sickness: '&c&cYou are not a participant of this siege and cannot be in the Siege Zone. Please leave or you will receive war sickness in %s seconds.' |
There was a problem hiding this comment.
🚧
These two war sickness fields above should be moved to the bottom of the file, i.e. under the 'Added in 0.06' comment
Goosius1
requested changes
Jan 21, 2021
Goosius1
reviewed
Jan 21, 2021
src/main/resources/english.yml
Outdated
| msg_inventory_degrade_warning: '&4WARNING: &cSome of your gear is close to breaking due to inventory degradation.' | ||
| msg_swa_remove_siege_success: '&bSuccessfully removed siege.' | ||
| msg_war_siege_occupied_towns_cannot_surrender: '&cOccupied towns cannot surrender.' | ||
|
|
There was a problem hiding this comment.
🚧
This file is showing a lot of changes in the "github pr files" view, even though your PR only adds 2 fields. This is generally risky to review. If at all possible, pls try to get ONLY these 2 fields showing up as the change. Perhaps grab a copy of the file from master, add the two fields, then replace the file in this branch.
…to war_sickness
# Conflicts: # src/main/java/com/gmail/goosius/siegewar/utils/SiegeWarSicknessUtil.java # src/main/resources/english.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
It has been a rule in most servers with siege war that you cannot be at a siege zone without a military rank or without being allied to either side, this is to ensure both sides are able to fight without having to worry about other players coming to troll as killing them has no award in siege points. This PR gives those trolls war sickness, which is a combination of potion effects that will make any player aware that they should not be at the siege zone or that they need to sort out their alliances or military ranks.
Players that do not want to participate in the siege but happen to live in the siege zone will receive a special type of war sickness which only includes Weakness V, this is to assure they actually dont participate as they deal no damage but they can still build in their own town
New Nodes/Commands/ConfigOptions:
2 Config options:
punish_non_siege_participants_in_siege_zone.enable_sickness - This is to toggle sickness on and off.
punish_non_siege_participants_in_siege_zone.seconds_warning - This is how long a player has to leave the siege zone before they get war sickness. No warning will be given if this is set to 0
Relevant Issue ticket:
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.