Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove leadership aura feature #42

Merged
merged 1 commit into from
Jan 16, 2021

Conversation

Goosius1
Copy link
Collaborator

Description:

  • The "leadership aura" feature is extra complexity without any added value
  • There is already an implicit leadership aura at work during battles, i.e. when players with actual leadership qualities are doing their thing, so an explicit dynamic points change is unnecessary to get the required effect.
  • By removing the feature, it also makes space for servers to enable much more usefully complex features such as the counterratack booster.
  • I checked with the testers channel and confirmed that this feature is not generally considered useful, and is already turned off on multiple servers.

New Nodes/Commands/ConfigOptions:

N/A


Relevant Issue ticket:

N/A


  • I have tested this pull request for defects on a server.

By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.

@Goosius1 Goosius1 merged commit 6abc704 into TownyAdvanced:master Jan 16, 2021
@Goosius1 Goosius1 deleted the remove_leadership_aura branch January 16, 2021 18:11
@LlmDl LlmDl added the enhancement New feature or request label Jan 16, 2021
@LlmDl LlmDl added this to the 0.0.7 milestone Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants