Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BannerControlSessionStartedEvent & TownPlunderedEvent #923

Merged
merged 3 commits into from
Aug 25, 2024

Conversation

tlm9201
Copy link
Contributor

@tlm9201 tlm9201 commented Aug 14, 2024

Description:


New Nodes/Commands/ConfigOptions:


Relevant Issue ticket:


  • I have tested this pull request for defects on a server.

By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the SiegeWar License for perpetuity.

@tlm9201 tlm9201 changed the title add BannerControlSessionStartedEvent Add a few events Aug 14, 2024
return siege;
}

@Nullable
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im pretty sure the plunder can remove the town so i think this is nullable

@LlmDl LlmDl changed the title Add a few events Add BannerControlSessionStartedEvent & TownPlunderedEvent Aug 25, 2024
@LlmDl LlmDl added this to the 2.14.0 milestone Aug 25, 2024
@LlmDl LlmDl merged commit 1075945 into TownyAdvanced:master Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants