Exception when you delete Town #3398

HotdogVanDriver · 2019-08-25T12:17:24Z

This ticket template is for bug/error reports. If you are suggesting a feature and not reporting a bug please delete all the text here and begin your ticket Title with Suggestion:

What steps will reproduce the problem?

Use deletion command
Confirm town deletion
Exception thrown over and over again in console

What is the expected output?

Town deletes normally

What is your Towny version?

0.94.0.5

What is your spigot/craftbukkit version?

Paper version git-Paper-135

Please use Pastebin.com to link the following files:

Skipping these files is not an option. It is the easiest way to diagnose an issue ticket properly. If you do skip this step then your ticket will most likely be deleted and you will be asked to resubmit.

Your full server startup from the logs\latest.log :
https://pastebin.com/YHyGfRsv
Your Towny config.yml (if using MySQL please remove password,) :
https://pastebin.com/YuryB2GZ
Your townyperms.yml :
https://pastebin.com/180Sgtzt
Your log's error :
https://pastebin.com/XmiiBk6K

(optional) If this is to do with permissions,
5. Your permissions file :
N/A

(optional) If this is to do with chat,
6. Your chatconfig.yml : N/A
7. Your channels.yml : N/A

LlmDl · 2019-08-25T12:26:13Z

The town that was deleted is having a hard time reverting the blocks back to their pre-claimed state.

Maybe the town was claimed on an older version of minecraft and towny?

HotdogVanDriver · 2019-08-25T15:02:56Z

I had only made the claim about 30 minutes prior. Didn't change the version minecraft or Towny in between. I only installed Towny today.

Just checked my console and it's throwing a new exception literally every single second:
https://pastebin.com/ym7yhYPa

LlmDl · 2019-08-25T17:05:04Z

Stop the server and delete the towny\data\regen.txt file.

winnipeg21 · 2019-08-25T21:14:14Z

Having the same issue, world regen is turned off. Config syntax is valid. Paperspigot 172

LlmDl · 2019-08-26T02:40:42Z

@winnipeg21 turned off in teh config or turned off in the world (use /tw toggle revertunclaim) the config is only for default settings.

Momshroom · 2019-09-03T02:05:31Z

Same issue: Paper 176 (1.14.4), Towny 0.94.0.6.
The town in question is created, then I immediately do /ta newday... town correctly gets deleted but console starts spamming errors.

Momshroom · 2019-09-03T02:12:19Z

I can confirm that toggling revertunclaim off before the town is deleted prevents this from happening.

LlmDl · 2019-09-03T02:18:03Z

@Momshroom anything that would make this town's plot snapshots strange? Which version of Towny were they claimed with, was it pre 0.93.1.0?

Momshroom · 2019-09-03T12:34:27Z

No. I claimed it immediately before the /ta newday command in 0.94.0.6. I was testing your iConomy fix. (Ty for that!)

LlmDl · 2019-09-03T12:42:17Z

Can you tell from the log if the snapshot had finished being made?

Momshroom · 2019-09-03T13:28:35Z

I included the whole latest.log file. Or did you mean the towny log?

…

On Tue, Sep 3, 2019 at 7:42 AM LlmDl ***@***.***> wrote: Can you tell from the log if the snapshot had finished being made? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3398?email_source=notifications&email_token=AEATM2D26UYRFPFY2JWOZILQHZLSXA5CNFSM4IPI4BYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5YBZKI#issuecomment-527441065>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEATM2HIHLWW3E6DUIQQUW3QHZLSXANCNFSM4IPI4BYA> .

Momshroom · 2019-09-03T15:14:03Z

Okay, after updating to 0.94.0.7, I toggled revertunclaim back on, made a new town, waited until the log said the plot snapshots were completed, and then caused the town to fall with /ta newday. It still spams console with the errors:

[15:13:06 WARN]: [Towny] Task #27 for Towny v0.94.0.7 generated an exception
java.lang.NullPointerException: null
        at com.palmergames.bukkit.towny.object.TownBlock.getWorldCoord(TownBlock.java:357) ~[?:?]
        at com.palmergames.bukkit.towny.regen.PlotBlockData.restoreNextBlock(PlotBlockData.java:99) ~[?:?]
        at com.palmergames.bukkit.towny.tasks.RepeatingTimerTask.run(RepeatingTimerTask.java:33) ~[?:?]
        at org.bukkit.craftbukkit.v1_14_R1.scheduler.CraftTask.run(CraftTask.java:84) ~[patched_1.14.4.jar:git-Paper-176]
        at org.bukkit.craftbukkit.v1_14_R1.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:452) ~[patched_1.14.4.jar:git-Paper-176]
        at net.minecraft.server.v1_14_R1.MinecraftServer.b(MinecraftServer.java:1148) ~[patched_1.14.4.jar:git-Paper-176]
        at net.minecraft.server.v1_14_R1.DedicatedServer.b(DedicatedServer.java:417) ~[patched_1.14.4.jar:git-Paper-176]
        at net.minecraft.server.v1_14_R1.MinecraftServer.a(MinecraftServer.java:1075) ~[patched_1.14.4.jar:git-Paper-176]
        at net.minecraft.server.v1_14_R1.MinecraftServer.run(MinecraftServer.java:919) ~[patched_1.14.4.jar:git-Paper-176]
        at java.lang.Thread.run(Thread.java:748) [?:1.8.0_222]
[15:13:07 WARN]: [Towny] Task #27 for Towny v0.94.0.7 generated an exception
java.lang.NullPointerException: null
        at com.palmergames.bukkit.towny.object.TownBlock.getWorldCoord(TownBlock.java:357) ~[?:?]
        at com.palmergames.bukkit.towny.regen.PlotBlockData.restoreNextBlock(PlotBlockData.java:99) ~[?:?]
        at com.palmergames.bukkit.towny.tasks.RepeatingTimerTask.run(RepeatingTimerTask.java:33) ~[?:?]
        at org.bukkit.craftbukkit.v1_14_R1.scheduler.CraftTask.run(CraftTask.java:84) ~[patched_1.14.4.jar:git-Paper-176]
        at org.bukkit.craftbukkit.v1_14_R1.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:452) ~[patched_1.14.4.jar:git-Paper-176]
        at net.minecraft.server.v1_14_R1.MinecraftServer.b(MinecraftServer.java:1148) ~[patched_1.14.4.jar:git-Paper-176]
        at net.minecraft.server.v1_14_R1.DedicatedServer.b(DedicatedServer.java:417) ~[patched_1.14.4.jar:git-Paper-176]
        at net.minecraft.server.v1_14_R1.MinecraftServer.a(MinecraftServer.java:1075) ~[patched_1.14.4.jar:git-Paper-176]
        at net.minecraft.server.v1_14_R1.MinecraftServer.run(MinecraftServer.java:919) ~[patched_1.14.4.jar:git-Paper-176]
        at java.lang.Thread.run(Thread.java:748) [?:1.8.0_222]

LlmDl · 2019-09-03T16:53:26Z

Ok, tracked this down to a change I made to removing TownBlocks. I'd made the change to greatly reduce spam Exception messages when a town has many townblocks removed. Looks like the fix I made has the side effect of deleting the townblocks too early. Probably have to revert the whole mess and see if there's another better way to solve the exception spam.

on Townblocks (Ticket #3398) - Had to revert a previous fix for Exception spam that involves the now-unused RemoveManyTownblocks.

LlmDl · 2019-09-03T22:11:48Z

This is not longer an issue as of 0.94.0.8, we are reverting the above fix.

LlmDl added a commit that referenced this issue Sep 3, 2019

- Potentially fix falling towns' plotsnapshots causing an Null Error

c67b968

on Townblocks (Ticket #3398) - Had to revert a previous fix for Exception spam that involves the now-unused RemoveManyTownblocks.

LlmDl mentioned this issue Sep 3, 2019

New Day upkeep that falls towns will output Exception spam to the log. #3338

Closed

LlmDl closed this as completed Sep 3, 2019

LlmDl mentioned this issue Sep 5, 2019

Log spamming on New Day #3407

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Exception when you delete Town #3398

Exception when you delete Town #3398

HotdogVanDriver commented Aug 25, 2019

LlmDl commented Aug 25, 2019

HotdogVanDriver commented Aug 25, 2019

LlmDl commented Aug 25, 2019

winnipeg21 commented Aug 25, 2019

LlmDl commented Aug 26, 2019

Momshroom commented Sep 3, 2019

Momshroom commented Sep 3, 2019

LlmDl commented Sep 3, 2019

Momshroom commented Sep 3, 2019

LlmDl commented Sep 3, 2019

Momshroom commented Sep 3, 2019 via email

Momshroom commented Sep 3, 2019 •

edited by LlmDl

Loading

LlmDl commented Sep 3, 2019

LlmDl commented Sep 3, 2019

Exception when you delete Town #3398

Exception when you delete Town #3398

Comments

HotdogVanDriver commented Aug 25, 2019

What steps will reproduce the problem?

What is the expected output?

What is your Towny version?

What is your spigot/craftbukkit version?

Please use Pastebin.com to link the following files:

LlmDl commented Aug 25, 2019

HotdogVanDriver commented Aug 25, 2019

LlmDl commented Aug 25, 2019

winnipeg21 commented Aug 25, 2019

LlmDl commented Aug 26, 2019

Momshroom commented Sep 3, 2019

Momshroom commented Sep 3, 2019

LlmDl commented Sep 3, 2019

Momshroom commented Sep 3, 2019

LlmDl commented Sep 3, 2019

Momshroom commented Sep 3, 2019 via email

Momshroom commented Sep 3, 2019 • edited by LlmDl Loading

LlmDl commented Sep 3, 2019

LlmDl commented Sep 3, 2019

Momshroom commented Sep 3, 2019 •

edited by LlmDl

Loading