Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help menu text fields not updating on language file reload #4220

Closed
winnipeg21 opened this issue Jul 27, 2020 · 2 comments
Closed

Help menu text fields not updating on language file reload #4220

winnipeg21 opened this issue Jul 27, 2020 · 2 comments

Comments

@winnipeg21
Copy link

What steps will reproduce the problem?

  1. Change any message in the language file that is part of a help menu (example changing /town's title
  2. Doing /townyadmin reload lang doesn't update that message

What is the expected output?

  1. /townyadmin reload lang should update every message field

What is your Towny version?

Do not say "latest".
0.96.2.8

What is your spigot/craftbukkit version?

Do not say "latest".
Paper #116

Please use Pastebin.com to link the following files:

Skipping these files is not an option. It is the easiest way to diagnose an issue ticket properly. If you do skip this step then your ticket will most likely be deleted and you will be asked to resubmit.

  1. Your full server startup from the logs\latest.log : https://pastebin.com/tkgu5FBP
  2. Your Towny config.yml (if using MySQL please remove password,) : https://pastebin.com/uRy8ZLMh
  3. Your townyperms.yml : https://pastebin.com/wu8u50gq
  4. Your log's error : No error in console really

Info (make my own section cause i'm a boss)

Basically if you example you edit the help_0: field in your language file to lets say &4&lGeneral Help you'd think by doing /townyadmin reload lang it would update that message to the right name/color. Well it sadly doesn't, to make it update you need to reload your server or restart it. TO BE NOTED: I am using a custom language file so no overwriting happens. I've only tested this with the first 4 help text fields.

@winnipeg21 winnipeg21 added the bug label Jul 27, 2020
@LlmDl
Copy link
Member

LlmDl commented Jul 27, 2020

So I've found out why this is occuring.

We store many of the help menus in static final array lists (which don't get touched again when the lang file is reloaded.)

Can probably work out something.

@winnipeg21
Copy link
Author

Capture
Hmm 🤔 Ight thanks for the help mate!

@LlmDl LlmDl closed this as completed in eaa9530 Jul 27, 2020
@LlmDl LlmDl added this to the 0.96.3.0 milestone Jul 27, 2020
Goosius1 pushed a commit to Goosius1/Towny that referenced this issue Aug 6, 2020
- Fix help menu's language strings not being retranslated when /ta
reload lang is used.
    - Closes TownyAdvanced#4220.
  - Fix cancelling a spawn causing an NPE.
    - Closes TownyAdvanced#4218.
  - Fix being able to confirm cancelled confirmations.
  - Clean up HelpMenu, courtesy of silverwolfg11 with PR TownyAdvanced#4223.
  - Fix new day task not collecting taxes properly, courtesy of
silverwolfg11 with PR TownyAdvanced#4225.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants