Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Ceding/giving chunks #7149

Closed
HerbertsStudios opened this issue Dec 28, 2023 · 6 comments · Fixed by #7319
Closed

Suggestion: Ceding/giving chunks #7149

HerbertsStudios opened this issue Dec 28, 2023 · 6 comments · Fixed by #7319
Assignees
Milestone

Comments

@HerbertsStudios
Copy link

Please explain your feature request to the best of your abilities:

right now theres no real good way to give chunks to other towns, maybe add a new perm node town.cede where you can do /plot cede town_name and it is given to the town

@LlmDl
Copy link
Member

LlmDl commented Dec 28, 2023

This gets a bit hairy in that there's all sorts of rules about distances between towns.

Before I add this I would want to have the code consolidated to something so there's no duplication of tests so things can stay consistent going forward.

FWIW admins can flip plots for towns using /ta set plot [townname] for players that want to do this now.

@Warriorrrr
Copy link
Member

What's wrong with unclaiming and having the other town re-claim?

@LlmDl
Copy link
Member

LlmDl commented Jan 3, 2024

I've had other people want to have something immediately flip plots in the past, where the server uses the revert on unclaim or plot-clearing features and unclaiming results in blocks being displaced.

#7151 is my first step towards making things a bit more uniform as for whether a plot should be allowed to flip to a different town.

@LlmDl LlmDl added this to the 0.100.2.0 milestone Feb 17, 2024
@Parthodys
Copy link

We still struggle with this and have had to make it a manual Staff task to exchange chunks for towns using the /ta set plot command if mayors request it.
I still think the best way to fix this would be to make towns able to sell plots to other towns, while only requiring the towns to border each other. That would ensure that both sides want it, adds an automated economic perspective to it and with no major distance rule issues since they were already neighbors.

Whats there to lose really? The perm wouldn't even have to be given by default, so server owners can at least choose whether to have it or not.

@LlmDl
Copy link
Member

LlmDl commented Feb 23, 2024

You don't have to contribute suggestions any longer.

@Parthodys
Copy link

You don't have to contribute suggestions any longer.

Oh? Sorry I didn't know that. You implemented my suggestion last week so had no idea there was an issue with me.
I just thought your earlier description sounded a lot like my then-sponsor suggestion #6295

@LlmDl LlmDl self-assigned this Mar 19, 2024
LlmDl added a commit that referenced this issue Mar 19, 2024
Players are tested to make sure that the town is not giving away their
homeblock, and that the other town is able to claim the townblock based
on all of Towny's rules for claiming, proximity, limits, ect.

Both giving and accepting players must accept Confirmations before the
land will change hands.

The command causes a TownPreClaimEvent to be thrown, which allows other
plugins to cancel the event.

Closes #7149.

  - New Command: /town cede plot {townname}
    - Attempts to give the townblock the player is stood in, to the
given town.

  - New Permission Node: towny.command.town.cede.plot
    - Child Node of towny.command.town.cede.* which is a child node of
towny.command.town.*
    - No changes required to the townyperms.yml
LlmDl added a commit that referenced this issue Mar 20, 2024
* Alphabetize the TownTabComplete list.

* Add /town cede plot {townname} command.

Players are tested to make sure that the town is not giving away their
homeblock, and that the other town is able to claim the townblock based
on all of Towny's rules for claiming, proximity, limits, ect.

Both giving and accepting players must accept Confirmations before the
land will change hands.

The command causes a TownPreClaimEvent to be thrown, which allows other
plugins to cancel the event.

Closes #7149.

  - New Command: /town cede plot {townname}
    - Attempts to give the townblock the player is stood in, to the
given town.

  - New Permission Node: towny.command.town.cede.plot
    - Child Node of towny.command.town.cede.* which is a child node of
towny.command.town.*
    - No changes required to the townyperms.yml

* Add cede to bannedNames.

* Correct node in enum.

* Fix messaging with no prefixes and add TownCedePlotEvent.
LlmDl added a commit that referenced this issue Mar 20, 2024
cede plot {townname}
    - Their ability to give a plot away also requires the other town to
be able to claim the plot,
      meaning that any rule applicable to /town claim is also applicable
here.
    - Closes #7149.
  - New Command: /town cede plot {townname}
    - Attempts to give the townblock the player is stood in, to the
given town.
  - New Permission Node: towny.command.town.cede.plot
    - Child Node of towny.command.town.cede.* which is a child node of
towny.command.town.*
    - No changes required to the townyperms.yml
  - API: Added TownCedePlotEvent
    - A cancellable event thrown when a mayor uses /town cede plot
{townname}.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants