Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Add ability for /ta town new NAME to bypass proximity claiming rules. #7163

Closed
tomhmagic opened this issue Jan 4, 2024 · 5 comments

Comments

@tomhmagic
Copy link

Please explain your feature request to the best of your abilities:

Add a force argument when using /ta set plot (town) to override proximity rules

could be a --force at the end of all the separate types of /ta set plot

@LlmDl
Copy link
Member

LlmDl commented Jan 4, 2024

The way this command currently works, is that if there is a town at the location, the townblock flips over to the specified town.

If there is no Town present you can use the normal /ta set plot townname rect 4 area claiming which will only select other plots with no town present.

The proximity rules are not applied to either of these.

@LlmDl LlmDl added the Need Feedback Something is required of the submitter. Tickets will be closed after 14 days with no feedback. label Jan 4, 2024
@tomhmagic
Copy link
Author

oh I may have miss remembered the command I ran, I was making some admin made towns for different things and couldn't create a town near another. Does /ta town new use proximity rules?

@LlmDl
Copy link
Member

LlmDl commented Jan 4, 2024

/ta town new NAME does go through the normal proximity tests. I'm doing to consolidation/refactoring on claiming rules code and when I'm done that it should be pretty easy to get things override-able for admins making new towns.

@LlmDl LlmDl changed the title Suggestion: Add force argument for /ta set plot to override proximity rules Suggestion: Add ability for /ta town new NAME to bypass proximity claiming rules. Jan 4, 2024
@LlmDl LlmDl added Label-Claiming Label-TownyAdmin and removed Need Feedback Something is required of the submitter. Tickets will be closed after 14 days with no feedback. labels Jan 4, 2024
@LlmDl LlmDl self-assigned this Jan 4, 2024
@LlmDl LlmDl added the Completed label Jan 4, 2024
LlmDl added a commit that referenced this issue Jan 4, 2024
@LlmDl LlmDl added this to the 0.100.1.0 milestone Jan 4, 2024
@LlmDl
Copy link
Member

LlmDl commented Jan 4, 2024

This one was a simple add to the PR already started.

@LlmDl LlmDl closed this as completed in 6e4c0f2 Jan 4, 2024
LlmDl added a commit that referenced this issue Jan 4, 2024
…s the rules for claiming. Closes #7163."

This reverts commit eab509d.
@LlmDl
Copy link
Member

LlmDl commented Jan 4, 2024

Turns out what I thought was only in the PR was in fact already merged previously, so it has gone in early.

LlmDl added a commit that referenced this issue Jan 10, 2024
…s the rules for claiming. Closes #7163."

This reverts commit eab509d.
LlmDl added a commit that referenced this issue Jan 10, 2024
* Add method to ProximityUtil to determine ability to claim land,

Add TownyAPI method to give other plugins an easy way to determine if
someone can claim an area.

Closes #6004.

* Add a unclaim api method to match the claiming version.

* Typo

* Revert "Add ability for admins using /ta town new [townname] to bypass the rules for claiming. Closes #7163."

This reverts commit eab509d.

* Lost a part of a previous commit in the rebase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants