You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
cancelled.
Not really happy with the implementation of this, as it changes our
DataSource pattern to one where only a single removeObject method
returns a boolean. The TownUtil change is also not ideal now or before
this PR as the Nation can be prevented from being deleted, while still
processing a refund.
Potential alternative solutions:
- Run the message in the DatabaseHandler method, and lose the custom
deleted by admin message sent to the admin who deleted the nation.
- Run the PreDeleteNation event before the removeNation(Nation) in order
to prevent the TownUtil method being made redundant, and causing issues.
Closes#7380.
iscancelled.
Uses the nation.exists to determine if the removal of the nation was
successful or not, and displays messages to match the outcome.
Closes#7380.
Supercedes #7381.
…celled. (#7383)
* Fix nation deleted message showing when a predeletenationevent
iscancelled.
Uses the nation.exists to determine if the removal of the nation was
successful or not, and displays messages to match the outcome.
Closes#7380.
Supercedes #7381.
* Remove event handler used in testing.
* Fix sending message to the non-existant nation.
* Do the same for TownUtil, removing call to sendPrefixedNationMessage.
What steps will reproduce the problem?
PreDeleteNationEvent
What is the expected output?
No deletion message is broadcast.
Towny version
0.100.2.4 and 0.100.2.5
Server version
git-Purpur-2169 (MC: 1.20.4)
Please use Pastebin.com to link the following files
The text was updated successfully, but these errors were encountered: