Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: Ability to add "list by" subcommands #7397

Closed
galacticwarrior9 opened this issue May 3, 2024 · 0 comments · Fixed by #7398
Closed

Suggestion: Ability to add "list by" subcommands #7397

galacticwarrior9 opened this issue May 3, 2024 · 0 comments · Fixed by #7398
Assignees
@LlmDl
Labels
Completed enhancement
Milestone
0.100.3.0

Comments

@galacticwarrior9
Copy link
Contributor

Please explain your feature request to the best of your abilities:

It would be nice if the API supported adding /[t|n] list by subcommands. For example, on my server we rank towns and nations by:

  • active residents
  • eligible voters (for democratic nations)
  • aggregate 'wealth' (includes more than town/nation banks)

But since these commands are detached from /[t|n] list by, it is difficult for players to remember that these rankings exist.
LlmDl added a commit that referenced this issue May 3, 2024
@LlmDl
API: add NATION_LIST_BY, TOWN_LIST_BY TownyCommandAddons.
dd73d64 
Allows plugins to extend towny's /t list by and /n list by commands with
their own list commands.

Closes #7397.
@LlmDl LlmDl mentioned this issue May 3, 2024
Merged
1 task
@LlmDl LlmDl self-assigned this May 3, 2024
@LlmDl LlmDl added the Completed label May 3, 2024
@LlmDl LlmDl added this to the 0.100.3.0 milestone May 3, 2024
LlmDl added a commit that referenced this issue May 6, 2024
@LlmDl
API: add NATION_LIST_BY, TOWN_LIST_BY TownyCommandAddons. (#7398)
d7f18b7 
Allows plugins to extend towny's /t list by and /n list by commands with
their own list commands.

Closes #7397.
LlmDl added a commit that referenced this issue May 6, 2024
@LlmDl
- Fix workflows running twice on pull requests, courtesy of Warrior
69ab200 
with PR #7402.
  - Fix Towny not loading on older minecraft servers missing
FileNameUtils modern methods, courtesy of Warrior with PR #7403.
    - Closes #7399.
  - Allow setting a default plot price of -1, courtesy of Warrior with
PR #7313.
    - A town can now prevent their plots going up for sale by setting a
plot price of -1, using /t set plotprice -1.
    - Closes #7295.
  - Add option to use world key instead of world name, courtesy of
gecko10000 with PR #7388. (First-Time Contributor!)
  - New Config Option:
plugin.interfacing.web_map.world_name_uses_world_key
    - Default: false
    - If enabled, the world name placeholder will be replaced with the
world key instead of the Bukkit name.
    - This should be enabled if you use SquareMap.
  - Bump adventure platform bukkit to 4.3.3-SNAPSHOT, courtesy of
Warrior with PR #7395.
    - Adds support for 1.20.5/6 in Towny.
  - API: add NATION_LIST_BY, TOWN_LIST_BY TownyCommandAddons.
    - Closes #7397.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LlmDl LlmDl

Labels
Completed enhancement
Projects
None yet
Milestone
0.100.3.0
Development

Successfully merging a pull request may close this issue.

API: add NATION_LIST_BY, TOWN_LIST_BY TownyCommandAddons. TownyAdvanced/Towny
2 participants
@LlmDl @galacticwarrior9