Make fields/objects that don't change Immutable #4171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This makes the fields of objects that don't change
final
it also prevents data-only objects from being mutable. Why does this matter? Mainly because objects with an unchangeable state are automatically thread-safe, and they don't suffer from weird state side effects.It's worth noting that the thread-safe point only applies to objects containing fields that are 1) all immutable or 2) some that are mutable and the mutable fields aren't publicly accessible.
This is important as many of our tasks run async whilst using these objects.
Some objects simply hold data, and have no reason to be mutable, therefore:
WorldCoord
- Now an immutable objectCoord
- Now An immutable objectAlso in many methods to reset a map we were using:
myMap = new HashMap<>();
This is not that efficient so it's been corrected to this:
myMap.clear();
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.