Metadata Improvements #4186
Merged
Metadata Improvements #4186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Jul 19, 2020
|
|
||
| private HashSet<CustomDataField<?>> metadata = null; | ||
| private Map<String, CustomDataField<?>> metadata = null; |
There was a problem hiding this comment.
Even though when I originally did this I set this to null as the default, I think we're better of making it non-null:
private Map<String, CustomDataField<?>> metadata = new HastMap<>();There was a problem hiding this comment.
Reason I kept it null is for lazy-loading. I don't think the majority of TownyObjects will have metadata so I rather not create new objects for all of them if they're not going to be used.
LlmDl
added a commit
that referenced
this pull request
Jul 23, 2020
#4205. - Metadata Improvements, courtesy of silverwolfg11 with PR #4186. - Do compression via tar and not zip, courtesy of Siris with PR #4195. - Tar does a lot better when unicode characters are being used in the database. - You can go back to using zip at your own risk, if that's your thing. - Removed Config Option: plugin.database.flatfile_backup - New Config Option: plugin.database.flatfile_backup_type - default: tar - Valid entries are: tar for tar.gz and zip for zip, use none for no backup. - Allow for nations and towns to set tags less than 4 characters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Previously it was hard to get a specific customdatafield from the metadata which is often what plugins wanted to do. This PR changes the internal set to a map keyed by the customdatafield key and offers new granular methods to fetch metadata.
The customdatafield object was not changed in order to retain legacy compatibility, however I'm like 95% sure this PR will break legacy metadata compatibility because it changes
getMetadata()to a collection rather than a set, so oh well.By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.