Fix taxes being below 0 #4243
Merged
Fix taxes being below 0 #4243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LlmDl
approved these changes
Aug 9, 2020
LlmDl
added a commit
that referenced
this pull request
Aug 9, 2020
- Prevent residents from being able to unclaim homeblocks, courtesy of silverworlfg11 with PR #4228. - Closes #4231. - Fix ClassNotFound exception due to old bungeecord version, courtesy of silverwolfg11 with PR #4238. - Fix taxes being below 0, courtesy of silverwolfg11 with PR #4243. - Fix economy bug with town confirmation, courtesy of silverwolfg11 with PR #4241. - GM Source fetching player suffix instead of prefix, courtesy of ElgarL with PR #4247. - Also fixes GM repo and solves issue with building Towny from source. - Update Reserve/TheNewChat maven repositories, courtesy of creatorfromhell with PR #4240.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This should fix nation tax defaulting to -1. For some reason weird, towns were explicitly setting their taxes to -1 by default and then returning the default town tax if the actual tax value was -1. This PR just sets the default town tax initially and resets a tax to default if it's below 0.
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.