Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TownBlockClaimCostCalculationEvent #5363

Merged
merged 19 commits into from
Oct 17, 2021
Merged

TownBlockClaimCostCalculationEvent #5363

merged 19 commits into from
Oct 17, 2021

Conversation

emanondev
Copy link

Description:

Added TownBlockClaimCostCalculationEvent to override townblock claim price with custom formulas


New Nodes/Commands/ConfigOptions:


Relevant Towny Issue ticket:


  • I have tested this pull request for defects on a server.

By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.

@LlmDl
Copy link
Member

LlmDl commented Oct 13, 2021

While I see the thinking behind putting the bonus and townblock purchasing together, they are actually very separate things.

I would argue this should be two events, one for claiming townblocks, the other for purchasing bonus blocks (which doesn't actually claim any land.)

emanondev and others added 8 commits October 17, 2021 01:37
Co-authored-by: LlmDl <LlmDlio@gmail.com>
Co-authored-by: LlmDl <LlmDlio@gmail.com>
Co-authored-by: LlmDl <LlmDlio@gmail.com>
Co-authored-by: LlmDl <LlmDlio@gmail.com>
Co-authored-by: LlmDl <LlmDlio@gmail.com>
Co-authored-by: LlmDl <LlmDlio@gmail.com>
Co-authored-by: LlmDl <LlmDlio@gmail.com>
Co-authored-by: LlmDl <LlmDlio@gmail.com>
@LlmDl LlmDl merged commit 0d85963 into TownyAdvanced:master Oct 17, 2021
@LlmDl LlmDl added this to the 0.97.3.0 milestone Oct 17, 2021
LlmDl added a commit that referenced this pull request Oct 17, 2021
Contributor!)
  - API: BonusBlockPurchaseCostCalculationEvent
    - Used to modify what towns pay when using /t buy bonus.
  - API: TownBlockClaimCostCalculationEvent
    - Used to modify what towns pay when using /t claim.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants