-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TownBlockClaimCostCalculationEvent #5363
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While I see the thinking behind putting the bonus and townblock purchasing together, they are actually very separate things. I would argue this should be two events, one for claiming townblocks, the other for purchasing bonus blocks (which doesn't actually claim any land.) |
LlmDl
requested changes
Oct 13, 2021
src/com/palmergames/bukkit/towny/event/BonusBlockClaimCostCalculationEvent.java
Show resolved
Hide resolved
src/com/palmergames/bukkit/towny/event/TownBlockClaimCostCalculationEvent.java
Show resolved
Hide resolved
LlmDl
requested changes
Oct 14, 2021
src/com/palmergames/bukkit/towny/event/BonusBlockClaimCostCalculationEvent.java
Outdated
Show resolved
Hide resolved
src/com/palmergames/bukkit/towny/event/TownBlockClaimCostCalculationEvent.java
Outdated
Show resolved
Hide resolved
src/com/palmergames/bukkit/towny/event/TownBlockClaimCostCalculationEvent.java
Outdated
Show resolved
Hide resolved
src/com/palmergames/bukkit/towny/event/BonusBlockClaimCostCalculationEvent.java
Outdated
Show resolved
Hide resolved
Co-authored-by: LlmDl <LlmDlio@gmail.com>
Co-authored-by: LlmDl <LlmDlio@gmail.com>
Co-authored-by: LlmDl <LlmDlio@gmail.com>
Co-authored-by: LlmDl <LlmDlio@gmail.com>
Co-authored-by: LlmDl <LlmDlio@gmail.com>
Co-authored-by: LlmDl <LlmDlio@gmail.com>
Co-authored-by: LlmDl <LlmDlio@gmail.com>
Co-authored-by: LlmDl <LlmDlio@gmail.com>
LlmDl
approved these changes
Oct 17, 2021
LlmDl
added a commit
that referenced
this pull request
Oct 17, 2021
Contributor!) - API: BonusBlockPurchaseCostCalculationEvent - Used to modify what towns pay when using /t buy bonus. - API: TownBlockClaimCostCalculationEvent - Used to modify what towns pay when using /t claim.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added TownBlockClaimCostCalculationEvent to override townblock claim price with custom formulas
New Nodes/Commands/ConfigOptions:
Relevant Towny Issue ticket:
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.