Update Toolchain, Test multiple Java Versions, and Use SDKMAN for JitPack configuration #5386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit supplants changes made in #5309 and the following direct commits: - 547c631 - d5362ba This re-write of the `jitpack.yml` file removes the direct jdk declaration and 3rd-party fallback script (`https://github.com/sormuras/bach/raw/master/install-jdk.sh`) in favor of utilizing the _SDKMAN!_ package manager included in Jitpack's VMs. It provides the following, without the need of a 3rd-party script: - Specification of the JDK version and distribution. (Jitpack defaults to OpenJDK 8) - Specification of the version of Apache Maven. (Jitpack defaults to 3.6.x at time of commit) The following considerations were made: - Use the latest available LTS JDK (Java 17) - Use the Microsoft OpenJDK builds, as it is the common vendor for Minecraft's distribution, and would therefore likely continue to include - Use the latest compatible Maven tooling (Maven 3.8.3, )
- HikariCP 4.0.3 >> 5.0.0 [changes](brettwooldridge/HikariCP@HikariCP-4.0.3...HikariCP-5.0.0) - JetBrains Annotations 21.0.1 >> 22.0.0 (Adds `@Blocking` and `@NonBlocking`) - Adventure Platform, Bukkit 4.0.0-SNAPSHOT >> 4.0.0 (Finalized Version) - Maven Javadoc Plugin 3.2.0 >> 3.3.1 [changes](apache/maven-javadoc-plugin@maven-javadoc-plugin-3.2.0...maven-javadoc-plugin-3.3.1)
- Use Eclipse Temurin 17 as OpenJDK provider (Replacing the legacy AdoptOpenJDK version) - Have compile-on-push.yml test against _both_ Java 16 and Java 17. - Use Java 17 for deployment builds.
Both Examination-API and Examination-String contain a file at `META-INF/versions/9/module-info.class` Since we are not a modular project, and we do not directly depend on these, it's safe to filter these out of the build to prevent collisions.
TheFlagCourier
added
the
dependencies
TheFlagCourier
changed the title
LlmDl
added a commit
that referenced
this pull request
Oct 20, 2021
JitPack configuration, courtesy of TheFlagCourier with PR #5386.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Updates the build toolchain. See commits for comments.
New Nodes/Commands/ConfigOptions:
No new nodes / config options / commands.
However, the following were changed:
Relevant Towny Issue ticket:
N/A
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.