Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom townblock types #5388

Merged
merged 28 commits into from
Dec 21, 2021
Merged

Custom townblock types #5388

merged 28 commits into from
Dec 21, 2021

Conversation

Warriorrrr
Copy link
Member

@Warriorrrr Warriorrrr commented Oct 20, 2021

Description:

TODO:

  • GUIs
  • more testing
  • Migration code
  • Add back plot set costs to /towny prices

New Nodes/Commands/ConfigOptions:


Relevant Towny Issue ticket:

Closes #5072


  • I have tested this pull request for defects on a server.

By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.

@Warriorrrr Warriorrrr self-assigned this Oct 20, 2021
@Warriorrrr Warriorrrr force-pushed the feature/custom-types branch from df62c45 to 759c73e Compare October 20, 2021 21:13
Copy link
Member

@LlmDl LlmDl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the Wilds plots will be broken in the current state. Otherwise it looks great and I'll end up testing it out shortly.

@LlmDl LlmDl added this to the 0.98.0.0 milestone Dec 2, 2021
LlmDl
LlmDl previously requested changes Dec 3, 2021
Copy link
Member

@LlmDl LlmDl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DailyTimerTask line 364 is preventing any plot tax collection from happening when a town has those three taxes set to 0.

Warriorrrr and others added 25 commits December 21, 2021 12:32
Fixes items not being added to the page if one was newly created.
Moves it to just above the jail plot section.
Moves comments into the config section header, add more explanations.
Mainly comments and javadocs, but also undoing a variable change in
PlotCommand.
Wilds plots get their own list, so that the /towny allowedblocks command
returns a proper list.

Updates the vastly out-of-date unclaimedZoneIgnoreIds list in the
config.

Removes wilds plot special case in PlayerCacheUtil.
@LlmDl LlmDl force-pushed the feature/custom-types branch from 9bad7ce to ccfc120 Compare December 21, 2021 18:37
@LlmDl LlmDl merged commit d43780d into master Dec 21, 2021
LlmDl added a commit that referenced this pull request Dec 21, 2021
    - TownBlocks are now able to be created in the config and also via
other plugins that use our API.
    - All of the previous townblocktypes will be imported to the new
config section.
    - Each TownBlockType has a name, cost, tax, map character, itemuse
list, switch list, and allowed blocks list.
  - New Command: /towny allowedblocks
    - Used to display what blocks are permitted to be used on
TownBlockTypes.
  - Removed Command: /towny farmblocks
    - Replaced with /towny allowedblocks.
@LlmDl LlmDl deleted the feature/custom-types branch December 30, 2021 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: TownyAPI - Allow for custom TownBlockType
2 participants