added town & nation contexts #5883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Galster-dev
commented
Apr 28, 2022
|
I think the only downside to this is that LP will check every context on each hasPermission test (or so I am told.) Adding further contexts will add additional load for servers that enable towny's LP contexts in the config. Not that it replaces your PR but there is already a node given towny.town.TOWNNAME to all Town members. This could always be given child nodes. I will defer to @Warriorrrr on this PR as he is the original author of our LP Contexts and knows more about it than I do. |
Warriorrrr
approved these changes
May 6, 2022
LlmDl
added a commit
that referenced
this pull request
May 6, 2022
PR #5883. (First-Time Contributor!) - These are contexts that apply per-town and per-nation, making it possible to give permissions to a single Town's members etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Permission per town/nation is a must-have feature for people doing automation without new plugins. I don't understand why it is not a thing yet. Here's a PR to fix it
New Nodes/Commands/ConfigOptions:
none.
Relevant Towny Issue ticket:
Haven't seen one (surprisingly)
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.