Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change language in unallied nation spawning error. #5940

Closed
wants to merge 1 commit into from
Closed

Change language in unallied nation spawning error. #5940

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 4, 2022

Description:

Currently, when a player tries to use /n spawn to a nation that is not allied with them, it simple says "That nation is not public" when it should suggest that nation is not affiliated with their nation, giving a hint at the problem lies with their relationship and not if the nation has enabled/disabled public.


New Nodes/Commands/ConfigOptions:

N/A


Relevant Towny Issue ticket:

EarthMC/Issue-Tracker#1524


  • I have tested this pull request for defects on a server.

By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.

Currently, when a player tries to use `/n spawn` to a nation that is not allied with them, it simple says "That nation is not public" when it should suggest that nation is not affiliated with their nation, giving a hint at the problem lies with their relationship and not if the nation has enabled/disabled public.
@ghost
Copy link
Author

ghost commented Jun 4, 2022

I am curious how a nation that is your ally, once they disable their nation spawn as public, how exactly with this error be handled?

@LlmDl
Copy link
Member

LlmDl commented Jun 4, 2022

I'm not certain this is an issue.

The player is not a part of or an ally of the nation, hence it reaching the UNAFFILIATED NationSpawnLevel. Since the nation isn't public, it says the nation isn't public. If the nation was public it would allow the /n spawn. The same is done for determining the TownSpawnLevel.

@LlmDl
Copy link
Member

LlmDl commented Jun 4, 2022

After discussing things in the other ticket, I think your new message could be used but only when public nation spawning is always denied on the server.

@LlmDl LlmDl closed this in 498b22f Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant