Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admin town command upkeep toggle #6052

Merged
merged 2 commits into from
Aug 3, 2022
Merged

Add admin town command upkeep toggle #6052

merged 2 commits into from
Aug 3, 2022

Conversation

Gamer153
Copy link

Description:

Towns can overwrite the upkeep setting of the config, but this setting wasn't modifyable per town by admins. This pull request adds a new admin town command toggle for upkeep.


New Nodes/Commands/ConfigOptions:

/ta town <town> toggle upkeep


Relevant Towny Issue ticket:


  • I have tested this pull request for defects on a server.

By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.

LlmDl
LlmDl previously requested changes Jul 21, 2022
Copy link
Member

@LlmDl LlmDl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will you also be adding a feature for nation upkeep? You included a lang string for them.

@Gamer153
Copy link
Author

I wanted to add this for nations too, but nations can't override the towny config setting, so I thought it isn't really necessary. Also, I've implemented the change you suggested.

@Gamer153 Gamer153 requested a review from LlmDl July 21, 2022 22:51
@LlmDl
Copy link
Member

LlmDl commented Jul 21, 2022

You'll need to rebase this branch, the en-US has had changes since it was begun.

@LlmDl LlmDl added this to the 0.98.4.0 milestone Aug 3, 2022
@LlmDl LlmDl merged commit 8f1df87 into TownyAdvanced:master Aug 3, 2022
LlmDl added a commit that referenced this pull request Aug 3, 2022
  - Add option to disallow numbers in town/nation names, courtesy of
Warriorrrr with PR #6068.
    - Closes #5954.
  - Allow spaces to be used in town/nation rename commands, courtesy of
Warriorrrr with PR #6067.
  - Make it easier to debug lang file formatting errors, courtesy of
Warriorrrr with PR #6066.
    - Closes #6036.
  - Fix /t deposit & /n deposit running sync, courtesy of Warriorrrr
with PR #6064.
  - Include the plot price in the /plot fs feedback message, courtesy of
Warriorrrr with PR #6062.
  - Ensure player gets feedback message when setting a group for sale,
courtesy of Warriorrrr with PR #6060.
  - Re-check group set cost after confirmation is accepted, courtesy of
Warriorrrr with PR #6058.
  - Add admin town command upkeep toggle, courtesy of Gamer153 with PR
#6052. (First-Time Contributor!)
  - New Command: /ta town NAME toggle upkeep
    - Toggles upkeep on or off for the given town.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants