API: Add TOWNYADMIN_TOWN and TOWNYADMIN_NATION CommandTypes #6179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added two new types for creating subcommands: TOWNYADMIN_TOWN and TOWNYADMIN_NATION which are triggered by /townyadmin town <town_name> and /townyadmin nation <nation_name> respectively
LlmDl
requested changes
Sep 20, 2022
LlmDl
changed the title
remove free spaces
|
Seems to be fixed |
|
There's more, I'll fix it up for you. |
|
Thanks! |
LlmDl
added a commit
that referenced
this pull request
Sep 20, 2022
courtesy of Lemar98 with PR #6179. (First-Time Contributor!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two new types for creating subcommands: TOWNYADMIN_TOWN and TOWNYADMIN_NATION which are triggered by /townyadmin town <town_name> and /townyadmin nation <nation_name> respectively
The purpose of this PR is to allow other developers to add their own subcommands for /townyadmin <town/nation> <government_name>. For example, /townyadmin town test mysubcommand.
I believe this will make the API more flexible
I tested this code on my local server paper 1.16.5
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.